Skip to content

Fix remaining Swift 6 concurrency issues#273

Closed
kieran-osgood-shopify wants to merge 1 commit into
graphite-base/273from
kieran-osgood/swift6/final-concurrency-cleanup
Closed

Fix remaining Swift 6 concurrency issues#273
kieran-osgood-shopify wants to merge 1 commit into
graphite-base/273from
kieran-osgood/swift6/final-concurrency-cleanup

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Stack Context

This stack incrementally prepares the Swift SDK and sample apps for Swift 6, with the final PR enabling Swift 6 language mode.

What?

Adds the last compatibility fixes needed immediately before flipping the language mode:

  • marks remaining shared state / mock types safe for Swift 6 checking
  • keeps the Checkout Kit configuration API usable from existing call sites
  • updates SwiftUI and web view tests for main-actor-isolated APIs
  • removes obsolete cache invalidation test setup from the renamed checkout web view flow

Why?

Keeping these fixes in a separate PR keeps the final language-mode PR focused on the actual compiler setting changes. This preserves the incremental stack so each step can be reviewed independently before kieran-osgood/05-13-featswift6languagemode turns Swift 6 on.

How to test

shadowenv exec --dir /Users/ko/src/github.com/Shopify/checkout-kit -- /opt/dev/bin/dev swift test

kieran-osgood-shopify commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.66% (319/348) 87.86% (181/206) 100% (82/82)

@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/final-concurrency-cleanup branch from 19620b7 to 505f1c5 Compare June 10, 2026 17:34
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 9ee9385 to a14d3d3 Compare June 11, 2026 08:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/final-concurrency-cleanup branch from 505f1c5 to 8267c91 Compare June 11, 2026 08:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from a14d3d3 to 6af3d02 Compare June 11, 2026 09:33
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/final-concurrency-cleanup branch from 8267c91 to 493753c Compare June 11, 2026 09:33
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 6af3d02 to 520d330 Compare June 11, 2026 10:01
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/final-concurrency-cleanup branch from 493753c to 1037e95 Compare June 11, 2026 10:01
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 520d330 to 78f74f0 Compare June 11, 2026 10:23
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/final-concurrency-cleanup branch from 1037e95 to 41050fe Compare June 11, 2026 10:23
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 78f74f0 to 8aeb5fa Compare June 11, 2026 10:32
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/final-concurrency-cleanup branch 2 times, most recently from 453f808 to 7371163 Compare June 11, 2026 13:08
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 8aeb5fa to 4259ad1 Compare June 11, 2026 13:08
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/final-concurrency-cleanup branch from 7371163 to ed1872a Compare June 12, 2026 10:58
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 4259ad1 to 6d48d8f Compare June 12, 2026 10:58
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/swift6/sample-concurrency-cleanup to graphite-base/273 June 12, 2026 12:54
@kieran-osgood-shopify

Copy link
Copy Markdown
Contributor Author

Closing as obsolete: this final cleanup branch has been dissolved into the semantic Swift 6 branches (#85, #89, #90, and #91), with generated/codegen cleanup in #87.

@kieran-osgood-shopify kieran-osgood-shopify deleted the kieran-osgood/swift6/final-concurrency-cleanup branch June 12, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant