Skip to content

[Performance] Memoize isShopify#7786

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-memoize-is-shopify-8086827328400609332
Draft

[Performance] Memoize isShopify#7786
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-memoize-is-shopify-8086827328400609332

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The isShopify function performs a disk check to see if the dev executable is present. This function is called multiple times during the CLI lifecycle, including for every analytics event. Memoizing the result avoids redundant disk I/O, which can measurably reduce the execution time of commands, especially when multiple analytics events are triggered.

WHAT is this pull request doing?

  • Memoizes the result of isShopify when called with the default process.env.
  • Uses a module-level promise to ensure that concurrent calls await the same operation.
  • Exposes an internal _resetIsShopify function to maintain test isolation.
  • Adds a unit test to verify that the file system check is only performed once.

How to test your changes?

CI

Post-release steps

N/A

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 8086827328400609332 started by @gonzaloriestra

The `isShopify` function performs a disk check to see if the `dev` executable is present. This function is called multiple times during the CLI lifecycle, including for every analytics event. Memoizing the result avoids redundant disk I/O, improving performance especially on systems with slower disks or under heavy load.

Summary:
- Memoizes the result of `isShopify` when called with the default `process.env`.
- Uses a module-level promise to handle concurrent calls correctly.
- Exposes `_resetIsShopify` for test isolation.
- Updates unit tests to verify memoization behavior.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/context/local.d.ts
@@ -173,4 +173,8 @@ export declare function getThemeKitAccessDomain(env?: NodeJS.ProcessEnv): string
  * @returns The domain to send OTEL metrics to.
  */
 export declare function opentelemetryDomain(env?: NodeJS.ProcessEnv): string;
+/**
+ * Resets the memoized value for the shopify check.
+ */
+export declare function _resetIsShopify(): void;
 export type CIMetadata = Metadata;
\ No newline at end of file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant