[Performance] Memoize isShopify#7786
Conversation
The `isShopify` function performs a disk check to see if the `dev` executable is present. This function is called multiple times during the CLI lifecycle, including for every analytics event. Memoizing the result avoids redundant disk I/O, improving performance especially on systems with slower disks or under heavy load. Summary: - Memoizes the result of `isShopify` when called with the default `process.env`. - Uses a module-level promise to handle concurrent calls correctly. - Exposes `_resetIsShopify` for test isolation. - Updates unit tests to verify memoization behavior.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/context/local.d.ts@@ -173,4 +173,8 @@ export declare function getThemeKitAccessDomain(env?: NodeJS.ProcessEnv): string
* @returns The domain to send OTEL metrics to.
*/
export declare function opentelemetryDomain(env?: NodeJS.ProcessEnv): string;
+/**
+ * Resets the memoized value for the shopify check.
+ */
+export declare function _resetIsShopify(): void;
export type CIMetadata = Metadata;
\ No newline at end of file
|
WHY are these changes introduced?
The
isShopifyfunction performs a disk check to see if thedevexecutable is present. This function is called multiple times during the CLI lifecycle, including for every analytics event. Memoizing the result avoids redundant disk I/O, which can measurably reduce the execution time of commands, especially when multiple analytics events are triggered.WHAT is this pull request doing?
isShopifywhen called with the defaultprocess.env._resetIsShopifyfunction to maintain test isolation.How to test your changes?
CI
Post-release steps
N/A
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 8086827328400609332 started by @gonzaloriestra