[Refactor] Use declarative .find() in import-extractor resolution helpers - #8347
[Refactor] Use declarative .find() in import-extractor resolution helpers#8347gonzaloriestra wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
What this PR does / why we need it
Refactors
resolveJSImportandresolveRustModuleinpackages/cli-kit/src/public/node/import-extractor.tsby replacing imperativefor...ofloops with declarativeArray.prototype.find()calls. Also replaces manual string slicing for extension extraction withextnamefrom./path.js.How to test your changes?
CI
Checklist
pnpm suppress-warningsfrom the root of the repository to record any new compiler warnings introduced by this PR./docsto reflect any user-facing changes in this PR.pnpm changesetif this PR contains user-facing changes or changes that should be published.pnpm run lintand fixed any linting errors.PR created automatically by Jules for task 11092848067801520960 started by @gonzaloriestra