Skip to content

[Refactor] Use declarative .find() in import-extractor resolution helpers - #8347

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
refactor-import-extractor-find-helpers-11092848067801520960
Draft

[Refactor] Use declarative .find() in import-extractor resolution helpers#8347
gonzaloriestra wants to merge 1 commit into
mainfrom
refactor-import-extractor-find-helpers-11092848067801520960

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Refactors resolveJSImport and resolveRustModule in packages/cli-kit/src/public/node/import-extractor.ts by replacing imperative for...of loops with declarative Array.prototype.find() calls. Also replaces manual string slicing for extension extraction with extname from ./path.js.

How to test your changes?

CI

Checklist

  • I have executed pnpm suppress-warnings from the root of the repository to record any new compiler warnings introduced by this PR.
  • I have updated the documentation in /docs to reflect any user-facing changes in this PR.
  • I have created a changeset using pnpm changeset if this PR contains user-facing changes or changes that should be published.
  • I have added tests to cover my changes.
  • I have run pnpm run lint and fixed any linting errors.
  • I have verified that all tests pass locally.

PR created automatically by Jules for task 11092848067801520960 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant