Ensure no unstaged changes after expanding liquid#514
Merged
Conversation
adampetro
force-pushed
the
ap.expand-liquid-check-unstaged
branch
4 times, most recently
from
04003f5 to
fc29359
Compare
adampetro
force-pushed
the
ap.expand-liquid-check-unstaged
branch
from
8ae4696 to
8f92311
Compare
davejcameron
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should check that there are no unstaged changes after expanding liquid
I had to remove/gitignore
yarn.lockbecause it changes depending on whether we've expanded liquid yet, and whether we're building for JS or TS