Update delivery customizations examples to use renamed targets#625
Open
maximus1108 wants to merge 1 commit intoupdate-function-templates-2025-07from
Open
Update delivery customizations examples to use renamed targets#625maximus1108 wants to merge 1 commit intoupdate-function-templates-2025-07from
maximus1108 wants to merge 1 commit intoupdate-function-templates-2025-07from
Conversation
maximus1108
commented
May 9, 2025
| "graphql-codegen": "graphql-codegen", | ||
| "vite": "vite" | ||
| "vite": "vite", | ||
| "test": "vitest" |
Author
There was a problem hiding this comment.
Added to simplify running the tests
maximus1108
requested review from
davejcameron,
hamishmorgan,
nickwesselman and
tjoyal
hamishmorgan
reviewed
May 9, 2025
hamishmorgan
left a comment
hamishmorgan
left a comment
There was a problem hiding this comment.
You've missed the operation attribute name change in a few places. I think you need to update the checkout/wasm/schema.graphql file too... though not entirely sure what that template is for.
Otherwise looks good
sample-apps/delivery-customizations/extensions/delivery-customization-js/src/run.js
Show resolved
Hide resolved
maximus1108
force-pushed
the
maxp/delivery-customizations-2025-07
branch
2 times, most recently
from
94b53fa to
c1f705e
Compare
maximus1108
force-pushed
the
maxp/delivery-customizations-2025-07
branch
from
c1f705e to
418d310
Compare
hamishmorgan
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the ongoing project to rationalise the function API
gsd#44156 | doc | style guide | slack
This PR updates the Delivery Customizations templates and examples
Specifically:
shopify app function schema)purchase.delivery-customization.run->cart.delivery-options.transform.runFunctionRunResult->CartDeliveryOptionsTransformRunResultRenameOperation->DeliveryOptionRenameOperation2025-07Testing the changes:
yarn testis JS dirscargo testin Rust dirsJS example:
Rust eample
