Ensure Rack config pragmas are kept during application building #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viralpraxis
force-pushed
the
keep-rack-config-pragmas
branch
from
6ad448f to
6825a37
Compare
casperisfine
force-pushed
the
keep-rack-config-pragmas
branch
from
6825a37 to
c078ecb
Compare
casperisfine
reviewed
Jun 6, 2025
casperisfine
force-pushed
the
keep-rack-config-pragmas
branch
2 times, most recently
from
335850c to
718bd35
Compare
viralpraxis
commented
Jun 6, 2025
Resolves Shopify#173 Prior to these changes, Ruby pragmas (including `frozen-string-literal`) were inserted in the wrong place. This might be a breaking change. co-authored-by: Jean Boussier <[email protected]>
viralpraxis
force-pushed
the
keep-rack-config-pragmas
branch
from
718bd35 to
1f0ab7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #173
Prior to these changes, Ruby pragmas (including
frozen-string-literal) were inserted in the wrong place.This might be a breaking change.