fix: Don't escape regex characters in test commands on Windows#4007
Open
BillionClaw wants to merge 1 commit intoShopify:mainfrom
Open
fix: Don't escape regex characters in test commands on Windows#4007BillionClaw wants to merge 1 commit intoShopify:mainfrom
BillionClaw wants to merge 1 commit intoShopify:mainfrom
Conversation
Shellwords.escape() is designed for Unix shells and incorrectly escapes characters like `$` on Windows. This causes test commands to fail when running tests in terminal on Windows because the regex pattern `/\^TestClass#test_method\$/` becomes `/\^TestClass#test_method\\$/`. On Windows, we skip Shellwords.escape() since Windows command line parsing doesn't require the same escaping rules for regex patterns. Fixes Shopify#3759
rafaelfranca
added
server
Member
|
Fix looks good. Can you sign the CLA please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3759
Shellwords.escape() is designed for Unix shells and incorrectly escapes characters like
$on Windows. This causes the "Run Test In Terminal" CodeLens feature to fail on Windows because the regex pattern becomes incorrectly escaped.Changes: