Improve NumParams locs
#733
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
force-pushed
the
Alex/improve-numparams-loc
branch
from
6f583a8 to
c1b8035
Compare
amomchilov
changed the base branch from
graphite-base/733
to
Alex/print-all-wq-parser-locs
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. |
amomchilov
commented
Oct 30, 2025
| token_t last_token; | ||
| // Stores the opening token (`{` or `do`) for the current block being parsed, | ||
| // used to set the location of numparams nodes | ||
| token_t current_block_opening_token; |
Author
There was a problem hiding this comment.
@Morriar can you help me come up with a way to avoid needing new context state like this?
amomchilov
changed the base branch from
Alex/print-all-wq-parser-locs
to
graphite-base/733
amomchilov
force-pushed
the
Alex/improve-numparams-loc
branch
from
c1b8035 to
0f39686
Compare
amomchilov
changed the base branch from
graphite-base/733
to
Alex/improve-numparams-loc-base
amomchilov
force-pushed
the
Alex/improve-numparams-loc
branch
from
0f39686 to
b0213ed
Compare
amomchilov
force-pushed
the
Alex/improve-numparams-loc-base
branch
2 times, most recently
from
2f7bef7 to
1f0b0b9
Compare
Author
|
Upstreamed in sorbet#9539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Needed for #667 and #730.
The
NumParamsnode location is set to the location of the first use of a numbered parameter within the block (like_1,_2, ...). This behaviour is really hard for me to mimic, so it's easier to first improve it, and match the new behaviour instead.