Add Prism AST node factory #762
Draft
+692
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexander Momchilov <[email protected]> Co-authored-by: Jesse Johnson <[email protected]> Co-authored-by: Kaan Ozkan <[email protected]>
allcre
force-pushed
the
ac-Add_Prism_AST_node_factory_for_Sorbet
branch
2 times, most recently
from
39674ea to
3697789
Compare
- Adds missing helper methods - Minor const changes
allcre
force-pushed
the
ac-Add_Prism_AST_node_factory_for_Sorbet
branch
from
3697789 to
2e62a0f
Compare
- Rename Send*/createSendNode to Call*/createCallNode for clarity - Fix const-correctness: use const Span<pm_node_t*> instead of Span<const pm_node_t*> to match Prism's C API and remove const_cast - Add new helper methods: Nil(), String(), TSelfType(), TAnything(), TAttachedClass(), T_Boolean(), T_Module() - Add ConstantReadNode/ConstantPathNode overloads taking pm_location_t - Simplify array construction using C-style arrays instead of std::array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test plan
See included automated tests.