Replace T::Module with Module in RBS comment signatures#2576
Open
Replace T::Module with Module in RBS comment signatures#2576
Conversation
T::Module is Sorbet runtime syntax. In RBS comments, the correct type is Module[top] (or Module[T.anything]), not T::Module[top]. This change only affects RBS comment signatures (#: and #| lines), leaving runtime Sorbet code (sig blocks, T.cast, T::Set, etc.) unchanged.
KaanOzkan
approved these changes
Apr 6, 2026
Contributor
KaanOzkan
left a comment
KaanOzkan
left a comment
There was a problem hiding this comment.
I assume this came from the Spoom sig to rbs translation. Should we fix it within the translator if it's in a comment?
amomchilov
approved these changes
Apr 6, 2026
Contributor
amomchilov
left a comment
amomchilov
left a comment
There was a problem hiding this comment.
My bad, I was the one who put in all the T:: :)
paracycle
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
T::Module[top]withModule[top]andT::Module[T.anything]withModule[T.anything]in all RBS comment signatures (#:and#|lines)T::Moduleis Sorbet runtime syntax; in RBS comments, the correct type is justModulesigblocks,T.cast,T::Set, etc.) is left unchangedTest plan