Fix Fabric→Forge fluid tank capacity not converting droplets to mB - #293
Closed
yu1745 wants to merge 2 commits into
Closed
Fix Fabric→Forge fluid tank capacity not converting droplets to mB#293yu1745 wants to merge 2 commits into
yu1745 wants to merge 2 commits into
Conversation
FluidStorageFluidHandler#getTankCapacity returned the raw Fabric Storage capacity (in droplets) without converting to Forge mB, unlike getFluidInTank/fill/drain which all convert via ForgeCompatUtil.toForgeBucket. As a result the Forge-side capacity appeared 81x too large (1 mB = 81 droplets), e.g. a 32-bucket tank showing as 2592 buckets. Return ForgeCompatUtil.toForgeBucket((int) view.getCapacity()) instead.
|
+1 on this, it causes some issues especially with the display of fluid containers, some fluid block recipes, and rarely with the measure of fullness between mods' fluid systems, been looking for the reason for a while! |
….jar + build-info.json）
Su5eD
added a commit
that referenced
this pull request
Aug 13, 2026
Supercedes #293 Co-authored-by: yu1745 <43715680+yu1745@users.noreply.github.com>
Member
|
Merged manually because the PR contains an unrelated file "build.sh" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes
FluidStorageFluidHandler#getTankCapacityreturning the raw Fabric Storage capacity (in droplets) without converting to Forge mB.getFluidInTank/fill/drainall convert viaForgeCompatUtil.toForgeBucket, butgetTankCapacitydid not. As a result the Forge-side capacity appeared 81x too large (1 mB = 81 droplets), e.g. a 32-bucket tank showing up as 2592 buckets.Change
No behavior change for the existing
fill/drain/getFluidInTankpaths.