Atkinson font added here for now#824
Open
timea-solid wants to merge 2 commits into
Open
Conversation
NoelDeMartin
reviewed
Jul 1, 2026
NoelDeMartin
left a comment
NoelDeMartin
left a comment
Member
There was a problem hiding this comment.
This can work for now, and maybe we could even release it like this... But we should discuss whether we want to add a dependency with google for the fonts. People using Solid will be particularly privacy-sensitive, so I don't know if they'll like seeing that every time they open SolidOS, they'll be pinging google's servers.
As per the web awesome fonts variables, I think it should be fine to simply define --wa-font-family-body as well. See their theming docs.
Member
Author
|
Consider also merging SolidOS/mashlib#441 (non blocking) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the font for now here.
However, it seems like it is overwritten by the --wa-font-family-body: ui-sans-serif, system-ui, sans-serif;
I also need to delete the font in mashlib light.css.