Open
Conversation
alejoe91
commented
Nov 14, 2025
h-mayorquin
reviewed
Nov 17, 2025
|
|
||
|
|
||
| def get_random_recording_slices( | ||
| def get_random_slices( |
Member
There was a problem hiding this comment.
This is too neutral no ? Lets find some thing like
get_random_slices_along_time
Member
Author
There was a problem hiding this comment.
get_random_time_slices?
Member
Author
There was a problem hiding this comment.
now renamed get_random_sample_slices
Member
|
Lets discuss this in detail. This is lots some semantic changes. |
Member
Author
What about a
|
…base-chunk-executor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a
ChunkExecutorwhich is agnostic to the recording and applies to any chunkableBaseExtractor(which definesget_sample_size(), get_num_samples(), get_num_segments()This is because we are working on a new "spikeinterface" for calcium imaging, and this refactor makes it suuuuper straightforward to use the same parallelization machinery for
Imagingobjects (which inherit from theBaseExtractor)Update 29/11/25
Following up on trying to make SI tools as general as possible for its calcium imaging "clone" (photon-mosaic) I made some more dramatic refactoring:
ChunkableMixinabstract mixin that implements all method needed by theChunkExecutorBaseRecordingspecific methods (e.g.,write_binary/write_memoryand more) are now in thechunkable_toolsand applicable to anyChunkableMixinobjectChunkableMixinhas a generalget_datafunction, so it can be used by many derived classes (e.g.,get_tracesfor recordings,get_videos/seriesfor imaging)get_shape(segment_index), which returns the buffer shape by segment_recording_segmentsand sorting objects_sorting_segments. Each class then implemented its ownadd_*function. Since segments are aBaseExtractorconcept, I centralized the definition (self.segments: List[BaseSegment] = []), added aself.segmentsproperty, and a centralizedadd_segmentfunction.@samuelgarcia @chrishalcrow @yger @h-mayorquin @JoeZiminski @zm711
Let me know what you think!!!