Implementing KNN referencing and a backup referencing mechanism for common_reference#4412
Open
zzhmark wants to merge 3 commits intoSpikeInterface:mainfrom
Open
Implementing KNN referencing and a backup referencing mechanism for common_reference#4412zzhmark wants to merge 3 commits intoSpikeInterface:mainfrom
zzhmark wants to merge 3 commits intoSpikeInterface:mainfrom
Conversation
backup reference for local reference when local channels too few; knn can be more robust than local as it ensures the # of reference channels
for more information, see https://pre-commit.ci
Contributor
Author
Member
|
Hi @zzhmark If I'm reading the implementation correctly, you are not discarding channels within the inner radius when computing nearest neighbors. I think this is the wrong behavior: if you rereference to closed-by channels, spiking signals will be essentially killed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






PR based on this issue: #4193
The new features are designed for ungrouped local referencing.
Changes in parameters:
reference: includeknnas an optionbackup_reference: allowingglobal,singleandknn(localis unstable) to take effect when local referencing cannot get enough #channels, default as globalnneighbors: used for knn referencing, i.e. #channels nearby used for referencingbackup_thr: when #channel found locally is below this, turn tobackup_reference, default as 1, i.e. no channel found. (we may also consider None to force explicit assignment)Changes in workflow:
referenceandbackup_referenceboth need preprocessing, all the elif are turned as if.knnpreprocessing in init (similar tolocal).local, setup if else to choose backup when #channels not meeting the requirement.