Open
Conversation
zm711
reviewed
Apr 4, 2026
Member
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
got interrupted I'll try to look over this more later.
| "amplitude_cutoff": {"greater": None, "less": 0.2}, | ||
| "num_spikes": {"greater": 300, "less": None}, | ||
| "rp_contamination": {"greater": None, "less": 0.1}, | ||
| "rpv": {"greater": None, "less": 0.1}, # applies to rp_contamination or sliding_rp_violation |
Member
There was a problem hiding this comment.
I wonder if it is better to keep this explicit for users? Since our qc possibilities are rp_contamination or sliding_rp_violation? Not sure...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to expose and enable all parameters available in native bombcell: