Allow reasonable CLIENT commands to proceed without admin mode enabled#3129
Open
mgravell wants to merge 2 commits into
Open
Allow reasonable CLIENT commands to proceed without admin mode enabled#3129mgravell wants to merge 2 commits into
mgravell wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3127 fix #3128
CLIENTwas considered an admin command (because ofCLIENT KILL,CLIENT PAUSE, etc)Execute(...)< 3.x means that it didn't actively search for admin commandsExecute(...)got smarter, and correctly identifiesCLIENTusageExecute(...)would get an exception when usingCLIENTAddLibraryNameSuffixusesExecute(...)internally, but usesFireAndForget- which means the error doesn't surface directly, but is reported by telemetry ([3.0.x] Known Behavior Change (Admin Command), but cannot trace back reason #3127)Here, we add logic to detect the sub-command - for now, only necessary for
Execute(...), but potentially it is versatile enough to use with other command types.We've also done an audit of the remaining commands (#3128) - it turns out that a small number of the
CLIENTones are probably all we'd want to handle. Other combinations are still explicitly disabled; new tests assert:AddLibraryNameSuffixworks (which we verify by issuing aGETNAME)