Conversation
Signed-off-by: David Longworth <djl@sent.com>
Signed-off-by: David Longworth <djl@sent.com>
Signed-off-by: David Longworth <djl@sent.com>
Signed-off-by: David Longworth <djl@sent.com>
Signed-off-by: David Longworth <djl@sent.com>
custGeom isn’t listed as a type gitbrent/PptxGenJS#1328 Signed-off-by: David Longworth <djl@sent.com>
giamir
approved these changes
Dec 15, 2025
Contributor
giamir
left a comment
giamir
left a comment
There was a problem hiding this comment.
Nice work. Since it does not affect the build and is a separate file I think it is ok to merge. It also works well in my local machine.
I am unsure if there is a benefit shipping the powerpoint file as part of the icons packages though. It would probably make more sense for that to update a deck in google drive (this one) with a version tag. Or maybe that is the plan already. I got a bit confused by the ppt file ending up in the dist folder since anything in there we upload to npm.
Signed-off-by: David Longworth <djl@sent.com>
Collaborator
Author
|
@giamir yes great point, I've moved to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
npm run generate:powerpointwhich creates a sub-set of icons which can be used in presentations - spots and 64x64 icons. Currently the process requires manual upload, but I will revisit adding the upload stage to a workflow or something.🔗 Output file here