Open
Conversation
Make use of DateTime and Duration captures backed by dicio-numbers
Stypox
force-pushed
the
add-calendar-skill
branch
from
b7bf286 to
647d7f7
Compare
Stypox
reviewed
Feb 26, 2026
Owner
There was a problem hiding this comment.
Thank you!
I pushed some more commits, and I rewrote a lot of stuff I didn't like. Also, I recently implemented support for datetime/duration/number capturing groups directly in the sentence matching algorithm (that only match parts of the sentence that actually represent a datetime/duration/number), and I therefore made use of them.
The sentences generated by AI were not very sensical 😅. I rewrote them as good as I could, but there are still some things that get misinterpreted, e.g. "remind me about whatever tomorrow at nine". And now the sentences file is a 1.5KiB monster 😅😅. I will need to improve the sentences before merging this. Any help would be appreciated!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm finally fairly happy with how the calendar skill is receiving input, sentences are structured, and behaving. One of the biggest hurdles with this implementation is handling relative times - "tomorrow" works just fine but "Monday" does not. Stuff like "evening/morning" just flat out does not work. If you are specific with date/time, it works very well.
I tried to cover as much ground with how a user might phrase things but input and suggestions are welcome!
Resolves #232