build: drop SwiftLint build-tool plugin from vendored CodeEdit packages#1678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building on Xcode 27 / macOS 27 fails with
Plug-in ended with uncaught signal: 5. The crash is the SwiftLint build-tool plugin bundled in the vendored CodeEdit packages:The prebuilt swiftlint binary can't load
sourcekitdunder the Xcode 27 toolchain. macOS 27 can't run the pinned Xcode 26.4.1, so there is no supported-toolchain workaround.Change
Remove the
SwiftLintbuild-tool plugin (and theSwiftLintPlugindependency) from:LocalPackages/CodeEditSourceEditor/Package.swiftLocalPackages/CodeEditTextView/Package.swiftThat plugin lints CodeEdit's own vendored source, not TablePro code. TablePro lints itself with the root
swiftlint+ the CI lint gate, so nothing is lost. The app targets build unchanged; only the per-build lint of vendored third-party code is dropped.Verification
xcodebuild ... build -skipPackagePluginValidationon Xcode 27 beta: BUILD SUCCEEDED.