#52 switch to license expression#53
Open
thompson-tomo wants to merge 1 commit intoTaiizor:developfrom
Open
Conversation
2 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR switches the package licensing metadata from a file-based approach to an SPDX license expression (MIT) across all project files, and removes the explicit packaging of the LICENSE file.
- Replaced
<PackageLicenseFile>entries with<PackageLicenseExpression>MIT</PackageLicenseExpression> - Removed
<None Include="..\..\LICENSE">…</None>sections to stop packaging the standalone LICENSE file - Applied the same change consistently across all UUID and serialization subproject
.csprojfiles
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/UUID/UUID.csproj | Set license expression to MIT and removed license file packaging |
| src/UUID.Serialization.System/UUID.Serialization.System.csproj | Set license expression to MIT and removed license file packaging |
| src/UUID.Serialization.Newtonsoft/UUID.Serialization.Newtonsoft.csproj | Set license expression to MIT and removed license file packaging |
| src/UUID.Serialization.MessagePack/UUID.Serialization.MessagePack.csproj | Set license expression to MIT and removed license file packaging |
| src/UUID.Serialization.Entity/UUID.Serialization.Entity.csproj | Set license expression to MIT and removed license file packaging |
| src/UUID.Serialization.Dapper/UUID.Serialization.Dapper.csproj | Set license expression to MIT and removed license file packaging |
Comments suppressed due to low confidence (2)
src/UUID/UUID.csproj:24
- [nitpick] Consider adding or updating a license badge in the README.md to reflect the new MIT license declaration in package metadata, ensuring consumers see the license upfront.
<PackageLicenseExpression>MIT</PackageLicenseExpression>
src/UUID/UUID.csproj:24
- [nitpick] The
MITlicense expression is duplicated in every project file; you could centralize this in a sharedDirectory.Build.propsto reduce repetition and simplify future license updates.
<PackageLicenseExpression>MIT</PackageLicenseExpression>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52