fix(db-sqlite-persistence-core): add schema-aware overloads to persistedCollectionOptions#1453
Open
merodiro wants to merge 1 commit intoTanStack:mainfrom
Open
fix(db-sqlite-persistence-core): add schema-aware overloads to persistedCollectionOptions#1453merodiro wants to merge 1 commit intoTanStack:mainfrom
merodiro wants to merge 1 commit intoTanStack:mainfrom
Conversation
…tedCollectionOptions persistedCollectionOptions was missing schema-aware overloads, causing TSchema to default to `never` when a schema was passed. This made the result incompatible with createCollection's schema overloads. Add four overloads matching the pattern used by localOnlyCollectionOptions and localStorageCollectionOptions: - schema provided + sync present - schema provided + sync absent - no schema + sync present - no schema + sync absent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1452
Summary
Note on error messages
Adding schema-aware overloads changes the order TypeScript evaluates overloads when a call is invalid. Previously, calling persistedCollectionOptions without persistence in sync-present mode would report the error on the function call itself. Now TypeScript reports it on the sync property inside the object literal, since the last overload it tries is the sync-absent one (which Omits sync). The type safety is unchanged - the call still fails to compile without persistence - only the error location and message differ. This is the same behavior seen in createCollection, which has 8 overloads.
Test plan