Skip to content

fix(query-core): replaceEqualDeep max depth (v4) #10037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lachlancollins merged 3 commits into from
Jan 17, 2026
+10 −3
Merged

fix(query-core): replaceEqualDeep max depth (v4) #10037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50833b6
fix(query-core): replaceEqualDeep max depth
TkDodo Jan 14, 2026
8dc0aa5
Merge branch 'v4' into feature/max-depth
manudeli Jan 17, 2026
cab5c34
Add changeset for query-core patch
manudeli Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/olive-clouds-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tanstack/query-core": patch
---

fix(query-core): replaceEqualDeep max depth
8 changes: 5 additions & 3 deletions packages/query-core/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,12 +310,14 @@ export function partialDeepEqual(a: any, b: any): boolean {
* If not, it will replace any deeply equal children of `b` with those of `a`.
* This can be used for structural sharing between JSON values for example.
*/
export function replaceEqualDeep<T>(a: unknown, b: T): T
export function replaceEqualDeep(a: any, b: any): any {
export function replaceEqualDeep<T>(a: unknown, b: T, depth?: number): T
export function replaceEqualDeep(a: any, b: any, depth = 0): any {
if (a === b) {
return a
}

if (depth > 500) return b

const array = isPlainArray(a) && isPlainArray(b)

if (array || (isPlainObject(a) && isPlainObject(b))) {
Expand All @@ -328,7 +330,7 @@ export function replaceEqualDeep(a: any, b: any): any {

for (let i = 0; i < bSize; i++) {
const key = array ? i : bItems[i]
copy[key] = replaceEqualDeep(a[key], b[key])
copy[key] = replaceEqualDeep(a[key], b[key], depth + 1)
if (copy[key] === a[key]) {
equalItems++
}
Expand Down