Skip to content

feat(angular): handle aggregatedCell in flexRender helper#6381

Merged
KevinVandy merged 2 commits into
betafrom
fix/angular-aggregated-cell-flex-render-convenience
Jul 5, 2026
Merged

feat(angular): handle aggregatedCell in flexRender helper#6381
KevinVandy merged 2 commits into
betafrom
fix/angular-aggregated-cell-flex-render-convenience

Conversation

@riccardoperra

@riccardoperra riccardoperra commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Align flexRender helper rendering like all other adapters to support getIsPlaceholder/getIsAggregated behavior

Summary by CodeRabbit

  • Bug Fixes
    • Improved table cell rendering for grouped data, including aggregated cells and placeholder cells.
    • Placeholder cells now render nothing, while aggregated cells display the appropriate content when available.
  • Documentation
    • Minor formatting update in the data guide.

@nx-cloud

nx-cloud Bot commented Jul 5, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 215f9e0

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 6m 54s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 21s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-05 11:44:09 UTC

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fe656ca3-9110-4751-9c87-bf019a0687dc

📥 Commits

Reviewing files that changed from the base of the PR and between 3c2f640 and f1d68bb.

📒 Files selected for processing (2)
  • docs/guide/data.md
  • packages/angular-table/src/helpers/flexRenderCell.ts

📝 Walkthrough

Walkthrough

Updates the FlexRenderCell directive's cell rendering logic to detect aggregated and placeholder grouping cells, rendering appropriate content or nulls for each case, with fallback to standard cell rendering. Also fixes Markdown emphasis styling in a documentation file.

Changes

Flex Render Cell Grouping Support

Layer / File(s) Summary
Aggregated/placeholder cell handling
packages/angular-table/src/helpers/flexRenderCell.ts
Adds optional checks for getIsAggregated() and getIsPlaceholder() on the cell instance; renders aggregatedCell (falling back to cell def) for aggregated cells, returns [null, null] for placeholder cells, and preserves the original rendering path otherwise.

Documentation Fix

Layer / File(s) Summary
Emphasis syntax correction
docs/guide/data.md
Changes Markdown emphasis for "rendering" from asterisks to underscores in the large-dataset guidance section.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main Angular flexRender change and is specific enough for history scanning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/angular-aggregated-cell-flex-render-convenience

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/alpine-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/alpine-table@6381

@tanstack/angular-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table@6381

@tanstack/angular-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table-devtools@6381

@tanstack/lit-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/lit-table@6381

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/TanStack/table/@tanstack/match-sorter-utils@6381

@tanstack/preact-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table@6381

@tanstack/preact-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table-devtools@6381

@tanstack/react-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table@6381

@tanstack/react-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table-devtools@6381

@tanstack/solid-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table@6381

@tanstack/solid-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table-devtools@6381

@tanstack/svelte-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/svelte-table@6381

@tanstack/table-core

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-core@6381

@tanstack/table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-devtools@6381

@tanstack/vue-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table@6381

@tanstack/vue-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table-devtools@6381

commit: f1d68bb

@KevinVandy KevinVandy merged commit c064306 into beta Jul 5, 2026
8 checks passed
@KevinVandy KevinVandy deleted the fix/angular-aggregated-cell-flex-render-convenience branch July 5, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants