fix: add explicit dimensions to navbar and marquee logos#789
fix: add explicit dimensions to navbar and marquee logos#789franklinjavier wants to merge 1 commit intoTanStack:mainfrom
Conversation
Without intrinsic dimensions the browser can't reserve space before images load, causing layout shift. Add width/height attributes to navbar logo SVGs and marquee brand logos.
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo logo components now have explicit width and height dimensions added. The Navbar's Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
width/heightto navbar logo SVG<img>tags (black and white variants)width/heightto marquee brand logo<img>tags and set explicitw-24 h-14classesWithout intrinsic dimensions, the browser can't reserve space before images load, causing layout shift.
Test plan
Summary by CodeRabbit