Add REPAIR_TIMING_MAX_PASSES_PER_ITER parameters#2591
Closed
eszpotanski wants to merge 3 commits intoThe-OpenROAD-Project:masterfrom
Closed
Add REPAIR_TIMING_MAX_PASSES_PER_ITER parameters#2591eszpotanski wants to merge 3 commits intoThe-OpenROAD-Project:masterfrom
REPAIR_TIMING_MAX_PASSES_PER_ITER parameters#2591eszpotanski wants to merge 3 commits intoThe-OpenROAD-Project:masterfrom
Conversation
eszpotanski
force-pushed
the
eszpot/max-passes-per-iter-params
branch
from
ac28d08 to
286e8c2
Compare
oharboe
reviewed
Nov 26, 2024
| } | ||
|
|
||
| repair_timing_helper | ||
| repair_timing_helper "cts" |
Collaborator
There was a problem hiding this comment.
remove quotes, not needed in .tcl
oharboe
reviewed
Nov 26, 2024
| - place | ||
| FP_REPAIR_TIMING_MAX_PASSES_PER_ITER: | ||
| description: > | ||
| Maximum number of repairs per iteration during repair_timing, called from floorplan. |
Collaborator
There was a problem hiding this comment.
more magic values? Every option makes a feature twice as hard to use.
oharboe
reviewed
Nov 26, 2024
| Maximum number of repairs per iteration during repair_timing, called from CTS. | ||
| default: 20 | ||
| stages: | ||
| - cts |
Collaborator
There was a problem hiding this comment.
A proliferation of the same variable for the same operation. This multiplies the number of variables... Not ideal...
oharboe
suggested changes
Nov 26, 2024
Collaborator
oharboe
left a comment
oharboe
left a comment
There was a problem hiding this comment.
each magic variable makes the feature twice as hard to use...
Can we make some better automatic policy here?
eszpotanski
force-pushed
the
eszpot/max-passes-per-iter-params
branch
from
286e8c2 to
63a054f
Compare
Signed-off-by: Eryk Szpotanski <eszpotanski@antmicro.com>
Signed-off-by: Eryk Szpotanski <eszpotanski@antmicro.com>
Signed-off-by: Eryk Szpotanski <eszpotanski@antmicro.com>
eszpotanski
force-pushed
the
eszpot/max-passes-per-iter-params
branch
from
63a054f to
ca642ca
Compare
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 21 days if no further activity occurs. Remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new variables for max number of repairs per iteration in
rsz::repairSetup, introduced in The-OpenROAD-Project/OpenROAD#6244. It also sets the best found values for a few designs.It adds:
FP_REPAIR_TIMING_MAX_PASSES_PER_ITER- max number of repairs per iteration during floorplan,CTS_REPAIR_TIMING_MAX_PASSES_PER_ITER- max number of repairs per iteration during CTS,GRT_REPAIR_TIMING_MAX_PASSES_PER_ITER- max number of repairs per iteration during GRT.