Remove gf12 wrappers

[openroad-ci]

No description provided.

[maliberty]

Why are the lvt cells removed (but not their gds)? This seems unrelated to wrapping.

[osamahammad21]

They are not removed, they are just added later in the config file.

[maliberty]

In that case why not move the gds too?

[osamahammad21]

sure

[maliberty]

Is there any use of wrapping remaining or can we remove the whole mechanism to do wrapping?

[osamahammad21]

Is there any use of wrapping remaining or can we remove the whole mechanism to do wrapping?

Not to the detailed router. Not sure about other parts of the flow.

[maliberty]

Is there any use of wrapping remaining or can we remove the whole mechanism to do wrapping?

Not to the detailed router. Not sure about other parts of the flow.

Wrapping is not drt specific. If you changed the config.mk you affected all steps already. I was more asking if there are any designs still with wrapping?

[osamahammad21]

To make sure I understand correctly, if I remove all the wrap_lefs, wrap_defs and additional_gds files from the configurations(not just move them to additionals), then no wrapping would happen and nothing should break, right?

[maliberty]

To make sure I understand correctly, if I remove all the wrap_lefs, wrap_defs and additional_gds files from the configurations(not just move them to additionals), then no wrapping would happen and nothing should break, right?

How is removing them different from moving them? They have to appear in additional or they wouldn't exist at all in the config.

[osamahammad21]

To make sure I understand correctly, if I remove all the wrap_lefs, wrap_defs and additional_gds files from the configurations(not just move them to additionals), then no wrapping would happen and nothing should break, right?

How is removing them different from moving them? They have to appear in additional or they wouldn't exist at all in the config.

Sorry got confused. I thought that these files are used for wrapping only and didn't understand that they hold the actual macros being used originally in the design.
As for your original question if there are any remaining designs that do have wrapping, I see gf12/bp_single/config_mpl2.mk the only remaining test that have wrapping still. I am not sure if it's part of the secure CI or not. But other than that, none of the designs have wrapping anymore.

[maliberty]

I think gf12/bp_single/config_mpl2.mk is an experiment to use mpl2 rather than manual macro placement. It isn't in the CI. Please make a follow on PR to remove the wrapping support from the flow itself.

[maliberty]

This was approved but never got merged. I see it now has a conflict. It would be nice to update this so we can finish removing the wrappers if possible. Not urgent.