bazel: fix tclZipfs.c patch application - #4420
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the subproject commits for OpenROAD, kepler-formal, and yosys, and adjusts a patch file for tcl_lang to include proper diff headers and updated line numbers. There are no review comments, and I have no feedback to provide.
Member
|
Why are all the submodule tools being bumped here? |
oharboe
force-pushed
the
fix-openroad-bump
branch
from
August 12, 2026 17:36
fb8bcd9 to
a10d60b
Compare
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
force-pushed
the
fix-openroad-bump
branch
from
August 12, 2026 17:37
a10d60b to
4969ea7
Compare
Collaborator
Author
Fixed. |
oharboe
force-pushed
the
fix-openroad-bump
branch
from
August 12, 2026 19:21
8edb42d to
4969ea7
Compare
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 61 design(s) checked — 0 with regression(s), 0 without a comparable baseline.
|
maliberty
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tclZipfs.cpatch (which fixes the<crypt.h>include collision with hermetic glibc) has been upstreamed into thetcl_langBazel module in the BCR (as of9.0.2.bcr.2).Because the BCR version now carries the patch natively, the
single_version_overrideinMODULE.bazelthat applies it a second time was failing withCONTENT_DOES_NOT_MATCH_TARGET. This PR drops the localsingle_version_overridepatch now that it is redundant.