-
Notifications
You must be signed in to change notification settings - Fork 751
rmp: eqy test check #8889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
b-chmiel
wants to merge
3
commits into
The-OpenROAD-Project:master
Choose a base branch
from
antmicro:add-eqy-for-rmp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
rmp: eqy test check #8889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
b1f7acb to
9418da2
Compare
Collaborator
|
Will review today |
Contributor
Author
|
@QuantamHD would you mind taking a look? |
Co-authored-by: Krzysztof Bieganski <[email protected]> Co-authored-by: Ryszard Rozak <[email protected]> Signed-off-by: Bartłomiej Chmiel <[email protected]>
Signed-off-by: Bartłomiej Chmiel <[email protected]>
9418da2 to
e28b5dd
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
rebased on 12f5d70 |
QuantamHD
reviewed
Dec 18, 2025
Collaborator
|
Lgtm, please have a look @maliberty |
Signed-off-by: Bartłomiej Chmiel <[email protected]>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds eqy check for gcd_annealing1 and gcd_annealing2 tests in rmp.
As those tests require loading liberty files for eqy, changed
run_equivalence_test's interface to allow selecting both a library directory (for globbing sources) and explicit listing of liberty files.Follow-up to #8437 (comment)