odb: Bmap writer #8899
Open
odb: Bmap writer #8899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| #include <fstream> | ||
| #include <iostream> | ||
| #include <string> |
Contributor
There was a problem hiding this comment.
warning: included header iostream is not used directly [misc-include-cleaner]
Suggested change
| #include <string> | |
| #include <string> |
src/odb/src/3dblox/bmapWriter.cpp
Outdated
| const auto inst_name = bump->getInst()->getName(); | ||
| const auto cell_type = bump->getInst()->getMaster()->getName(); | ||
| auto point = bump->getInst()->getOrigin(); | ||
| bmap_file << inst_name + " " + cell_type + " " |
Contributor
There was a problem hiding this comment.
warning: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation]
bmap_file << inst_name + " " + cell_type + " "
^
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
osamahammad21
requested changes
Nov 26, 2025
Signed-off-by: Rafael Moresco <[email protected]>
Signed-off-by: Rafael Moresco <[email protected]>
Signed-off-by: Rafael Moresco <[email protected]>
Signed-off-by: Rafael Moresco <[email protected]>
Signed-off-by: Rafael Moresco <[email protected]>
rafaelmoresco
force-pushed
the
bmapWriter
branch
from
0e9b114 to
e32c078
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Rafael Moresco <[email protected]>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.