gui: new tcl command for worst path image #9127
Conversation
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Tcl command gui::show_worst_path to highlight the worst timing path in the GUI. The implementation is mostly correct and follows the existing structure of the GUI code. However, I've found one critical bug in the implementation that needs to be addressed.
|
clang-tidy review says "All clean, LGTM! 👍" |
check for invalid objects, rename function, remove unecessary selectedCaptureRowChanged() Signed-off-by: Augusto Berndt <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@gudeh it occurred to me that it might be useful to have a way to hide the timing path from TCL as well. Otherwise this command becomes a one-way thing in the scripts |
| gui->saveHistogramImage(filename, mode, width_px, height_px); | ||
| } | ||
|
|
||
| void show_worst_path(bool setup = true) |
Signed-off-by: Augusto Berndt <[email protected]>
I included a 
|
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
3 participants
Allows for automatically generating the worst path image at the final report from ORFS.
gui::show_worst_path