test/orfs/gcd: command line adjustable clock period #9147
Conversation
First build:
bazelisk build test/orfs/gcd:gcd_synth
Observe that clock period is picked up from variable and written
out by write_sdc after synthesis, hence no further dependency on
ABC_CLOCK_PERIOD_IN_PS variable:
$ grep create_clock $(bazelisk info bazel-bin)/test/orfs/gcd/results/asap7/gcd/base/1_synth.sdc
create_clock -name core_clock -period 310.0010 [get_ports {clk}]
Signed-off-by: Øyvind Harboe <[email protected]>
|
@MrAMS FYI |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request makes the clock period for the gcd test design configurable via a build argument. This is achieved by reading the ABC_CLOCK_PERIOD_IN_PS environment variable in the SDC file. The changes are correct and achieve the intended goal. I've added one suggestion to improve the robustness of the SDC script by providing a default value for the clock period in case the environment variable is not set.
|
clang-tidy review says "All clean, LGTM! 👍" |
| "OPENROAD_HIERARCHICAL": "1", | ||
| # Demonstrate clock period specified in arguments, useful | ||
| # for Optuna scripts. | ||
| "ABC_CLOCK_PERIOD_IN_PS": "310.001", |
There was a problem hiding this comment.
Curious why you went for 310.001 and not 310
There was a problem hiding this comment.
Same number as it used to be, but textually different, so I was in no doubt it is working and I don't have to redo metadata for tests.
2 participants
First build:
Observe that clock period is picked up from variable and written out by write_sdc after synthesis, hence no further dependency on ABC_CLOCK_PERIOD_IN_PS variable: