Skip to content

Conversation

@litneet64
Copy link
Contributor

Fixes issue from #9150 . As its a one-line fix, merge should be fairly simple

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes the path for the openroad binary in the multi-stage Docker build. The change in the Dockerfile updates the COPY instruction to point to /OpenROAD/build/bin/openroad, which aligns with the RUNTIME_OUTPUT_DIRECTORY specified in the CMake configuration. This is a necessary and accurate one-line fix to ensure the Docker image is built with the correct binary.

@litneet64
Copy link
Contributor Author

The DCO failing check is related to me not cryptographically signing the commit for this one-liner

@maliberty
Copy link
Member

I didn't see this PR before I opened #9152. If you want to sign the commit we can merge this one otherwise we can close it in favor of the other. The details link by DCO gives more details.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@litneet64
Copy link
Contributor Author

I didn't see this PR before I opened #9152. If you want to sign the commit we can merge this one otherwise we can close it in favor of the other. The details link by DCO gives more details.

Thanks for not just merging the other branch immediately. Signed the commit btw

@maliberty maliberty enabled auto-merge December 26, 2025 05:18
@maliberty maliberty merged commit 0502342 into The-OpenROAD-Project:master Dec 26, 2025
13 checks passed
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants