Fix/bubble sort negative numbers#7197
Closed
P-Ved wants to merge 2 commits intoTheAlgorithms:masterfrom
Closed
Conversation
- Added testBubbleSortNegativeNumbers to verify sorting works correctly with negative values - Ensures the sort handles negative numbers properly
test: improve BinarySearch tests and add null input handling test: enhance Factorial tests and add large input coverage test: correct GCD tests for negative inputs and improve coverage test: improve FibonacciNumberCheck tests and add edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perfect 👍
Below is a clear, complete, and easy-to-read description that includes EVERYTHING you did with my help, written in simple language so any user or maintainer can quickly understand it.
You can directly copy-paste this as your PR description.
📄 Pull Request Description (Simple & Complete)
What changes did I make?
In this pull request, I improved the unit tests for multiple algorithms to make them more reliable, clearer, and better at handling edge cases.
Detailed summary of changes
Bubble Sort
Binary Search
Factorial
GCD (Greatest Common Divisor)
Fibonacci Number Check
Why are these changes important?
Did I change any algorithm logic?
❌ No.
All changes are test-only. The algorithm implementations remain unchanged.