docs: cross-reference nth-fibonacci implementations via javadocs#7497
Open
DishaSethi wants to merge 2 commits into
Open
docs: cross-reference nth-fibonacci implementations via javadocs#7497DishaSethi wants to merge 2 commits into
DishaSethi wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7497 +/- ##
============================================
+ Coverage 79.91% 79.92% +0.01%
- Complexity 7353 7356 +3
============================================
Files 811 811
Lines 23879 23879
Branches 4705 4705
============================================
+ Hits 19082 19086 +4
+ Misses 4036 4035 -1
+ Partials 761 758 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DishaSethi
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.javaDescription
The n-th Fibonacci sequence is implemented across several files using entirely different paradigms (Iterative, Streams, Binet's Formula, Recursion, and DP). Currently, a learner looking at one file has no way of knowing the other approaches exist.
Proposed change
Added standard Javadoc
{@link}cross-references to the header of the following files:maths/FibonacciLoop.javamaths/FibonacciJavaStreams.javamaths/FibonacciNumberCheck.javamaths/FibonacciNumberGoldenRation.javadynamicprogramming/Fibonacci.javarecursion/FibonacciSeries.javaThis drastically improves discoverability for learners trying to compare algorithmic approaches, without disrupting the existing package hierarchy.
Fixes #7455