Skip to content

Fix x_demonimator → x_denominator typo in lamberts_ellipsoidal_distance.py #14433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ManVT26 wants to merge 2 commits into from
Closed

Fix x_demonimator → x_denominator typo in lamberts_ellipsoidal_distance.py #14433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12822a9
Fix demonimator typo
manangithubiitm Mar 23, 2026
35dd8b2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions geodesy/lamberts_ellipsoidal_distance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@
# Intermediate X value
# X = (sigma - sin(sigma)) * sin^2Pcos^2Q / cos^2(sigma/2)
x_numerator = (sin(p_value) ** 2) * (cos(q_value) ** 2)
x_demonimator = cos(sigma / 2) ** 2
x_value = (sigma - sin(sigma)) * (x_numerator / x_demonimator)
x_denominator = cos(sigma / 2) ** 2
x_value = (sigma - sin(sigma)) * (x_numerator / x_denominator)

# Intermediate Y value
# Y = (sigma + sin(sigma)) * cos^2Psin^2Q / sin^2(sigma/2)
Expand All @@ -107,6 +107,11 @@
return EQUATORIAL_RADIUS * (sigma - ((flattening / 2) * (x_value + y_value)))


print(
f"SF-Yosemite: {lamberts_ellipsoidal_distance(37.774856, -122.424227, 37.864742, -119.537521):0,.0f}"

Check failure on line 111 in geodesy/lamberts_ellipsoidal_distance.py

View workflow job for this annotation

GitHub Actions / ruff

ruff (E501) 

geodesy/lamberts_ellipsoidal_distance.py:111:89: E501 Line too long (105 > 88)
)
print(f"Expected ~254km but got ???")

Check failure on line 113 in geodesy/lamberts_ellipsoidal_distance.py

View workflow job for this annotation

GitHub Actions / ruff

ruff (F541) 

geodesy/lamberts_ellipsoidal_distance.py:113:7: F541 f-string without any placeholders
  help: Remove extraneous `f` prefix

if __name__ == "__main__":
import doctest

Expand Down
Loading