Skip to content

feat(conversions): add input validation and fix bugs in Roman Numerals#14871

Open
aoright wants to merge 1 commit into
TheAlgorithms:masterfrom
aoright:fix-roman-numerals
Open

feat(conversions): add input validation and fix bugs in Roman Numerals#14871
aoright wants to merge 1 commit into
TheAlgorithms:masterfrom
aoright:fix-roman-numerals

Conversation

@aoright

@aoright aoright commented Jun 29, 2026

Copy link
Copy Markdown

Describe your change:

This PR adds input validation, lowercase input support, and fixes boundary bugs in conversions/roman_numerals.py:

  • roman_to_int: Seamlessly converts lowercase input strings (e.g. "iii" -> 3) and raises a proper ValueError with clear messages for empty or invalid inputs.
  • int_to_roman: Validates that the input is an integer in the range 1 <= number <= 3999. Raises ValueError for out-of-range/non-integer inputs instead of returning incorrect values (e.g., int_to_roman(-5) used to return "CMXCV").
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant