fix(machine_learning): prevent log(0) and divide-by-zero warnings/NaN in kullback_leibler_divergence#14874
Open
aoright wants to merge 1 commit into
Open
Conversation
… in kullback_leibler_divergence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
This PR fixes a bug where
kullback_leibler_divergenceraisesRuntimeWarningand returnsnanorinfunder zero probabilities:y_true(since (0 \log 0 = 0) by definition).y_predto a small value (e.g.1e-15) to prevent division by zero or log of zero.RuntimeWarningwarnings by calculating math operations only on valid masked elements.Checklist: