Open
Conversation
TheLastProject
requested changes
Jun 19, 2021
| <string name="detected_flip_over">Call decline detected</string> | ||
| <string name="could_not_bind_sensor">Could not find any proximity sensor or accelerometer on your device. Cannot continue.</string> | ||
| <string name="feature_raise_to_answer">Answer by holding your device up to your ear</string> | ||
| <string name="feature_flip_over_to_decline">Hang up without answering by putting your device down screen-first</string> |
Owner
There was a problem hiding this comment.
Not a fan of renaming "decline" to "hang up without answering". It's way longer and "decline" is a really well-known word that every phone user really will know.
Contributor
Author
There was a problem hiding this comment.
It breaks down into "reject vs. decline", with some other options.
There is nothing for hold/postpone, so there is no consistency in using all the technical terms that way. The other strings already hinge on "hang up".
"Call decline detected" is not idiomatic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.