foundations/12_calculator: Add clearer factorial explanation#644
Open
dantoms wants to merge 1 commit intoTheOdinProject:mainfrom
Open
foundations/12_calculator: Add clearer factorial explanation#644dantoms wants to merge 1 commit intoTheOdinProject:mainfrom
dantoms wants to merge 1 commit intoTheOdinProject:mainfrom
Conversation
mao-sz
requested changes
Apr 6, 2026
Contributor
mao-sz
left a comment
There was a problem hiding this comment.
Thanks for this. I don't think we need a whole headed section on what a factorial is though. It looks a little odd visually, especially when it's just for 1 of the 6 tasks, and the section ends up including the last paragraph which is not related to it.
I think it'll be better to just replace the link with a resource that gives a simpler definition up front.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
The link to the full wikipedia page for factorials left learners looking at complex mathematical equations when simply giving a short explanation is far more beneficial
This PR
Issue
Closes #XXXXX
Additional Information
https://discord.com/channels/505093832157691914/505093832157691916/1490444532624392326
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection/solutionsfolder