ruby exercises: change directory names to follow name convention#102
Open
DennisNeu wants to merge 1 commit intoTheOdinProject:mainfrom
Open
ruby exercises: change directory names to follow name convention#102DennisNeu wants to merge 1 commit intoTheOdinProject:mainfrom
DennisNeu wants to merge 1 commit intoTheOdinProject:mainfrom
Conversation
rlmoser99
requested changes
Aug 3, 2024
Member
rlmoser99
left a comment
There was a problem hiding this comment.
Thank you for taking the time to make this PR (and issue). However, before we can merge in, we need to update the instructions in this README:
https://github.com/TheOdinProject/ruby-exercises/blob/main/ruby_basics/README.md
|
@rlmoser99 Can I update the instructions in this README to follow his rename? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
The directories in "ruby exercises" don't match the naming convention. With this pull request, directory names are changed to match the convention ("1_data_types" -> "01_data_types"), thus putting folders into a nice, readable order and making navigating files easier.
This PR
Issue
Closes #101
Pull Request Requirements
location of change: brief description of changeformat, e.g.Data types exercise: Update spec filesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesectionsolutionsbranch, I have created another PR (and linked it to this PR).