chore: new no-loops branch - #2543
Conversation
GitHub Actions
Inactive
GitHub Actions
Inactive
| return declarativeShadowVariableDescriptorList; | ||
| } | ||
|
|
||
| public boolean hasAnyShadowVariablesInconsistentMember() { |
There was a problem hiding this comment.
Arguably we can make this a field that is precomputed as the entity descriptors are being built. (Not sure how often this is called and from where; may be a moot point.)
There was a problem hiding this comment.
Called once to determine if inconsistent solutions should be ignored. Result is already cached on the score director.
| for (var i = 0; i < groupEntityIds.length; i++) { | ||
| var groupEntity = groupEntities[i]; | ||
| var groupEntityId = groupEntityIds[i]; | ||
| if (!ignoreInconsistentSolutions || !consistencyProcessed) { |
There was a problem hiding this comment.
I'd flip the condition and start with the other branch. Easier to read that way, without all that negation.
There was a problem hiding this comment.
There is no other branch though; I can flip it through de morgans though.
triceo
left a comment
triceo
left a comment
There was a problem hiding this comment.
Went over it all over again; adding some comments, likely for things I did not notice before.
I suggest we start writing docs for this; the docs need to list all the behaviors and it will be easy to forget some, if we try to write the docs at the very end of the process.
GitHub Actions
Inactive
GitHub Actions
Inactive
|
2 participants
The no-loops branch has a ton of conflicts with main; to have a meaniful diff, the PR is based on main (although it will replace no-loops via a force push). If approved, it will replace the existing no-loops branch which cannot be cleanly merged currently.