dataflow: Account for probe handles being dropped#490
Open
petrosagg wants to merge 1 commit intoTimelyDataflow:masterfrom
Open
dataflow: Account for probe handles being dropped#490petrosagg wants to merge 1 commit intoTimelyDataflow:masterfrom
petrosagg wants to merge 1 commit intoTimelyDataflow:masterfrom
Conversation
The lifetime of a probe handle is not attached to any particular dataflow and users are free to connect them to streams of multiple dataflows. This PR handles the situation in which a probe handle is connected to two separate dataflows and one of them drops. Previously the handle would have its frontier stuck because the old handle wouldn't provide any updates anymore. The solution is that each handle keeps track of its own changes and removes them from the overall calculation on drop. Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lifetime of a probe handle is not attached to any particular dataflow and users are free to connect them to streams of multiple dataflows.
This PR handles the situation in which a probe handle is connected to two separate dataflows and one of them drops. Previously the handle would have its frontier stuck because the old handle wouldn't provide any updates anymore.
The implemented solution is that each handle keeps track of its own changes and removes them from the overall calculation on drop.