fix for issue : https://github.com/Totodore/socketioxide/issues/627#628
Closed
Julian332 wants to merge 3 commits intoTotodore:mainfrom
Closed
fix for issue : https://github.com/Totodore/socketioxide/issues/627#628Julian332 wants to merge 3 commits intoTotodore:mainfrom
Julian332 wants to merge 3 commits intoTotodore:mainfrom
Conversation
CodSpeed Performance ReportMerging #628 will not alter performanceComparing Summary
|
Owner
|
Hey, thanks for your PR, could you also add a regression test please? I'll try to do review this week |
Author
Owner
|
By regression test I mean a test that fails without your fix and passes thanks to your fix. |
Author
hello,I have add that test |
Owner
|
Fixed and released in socketioxide v0.18.1. Sorry for the delay @Julian332. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
fix for issue : #627
Solution
because connect fn is stucked, so it executed after on_disconnect ,this insert a entry(sid , eio(closed) ) to namespace , so remove this entry if found eio is closed