Updated tar and node-gyp versions to the higher versions#1853
Updated tar and node-gyp versions to the higher versions#1853igeto wants to merge 1 commit intoTryGhost:masterfrom
Conversation
WalkthroughThis pull request updates dependency versions in package.json. The Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "node-addon-api": "^7.0.0", | ||
| "prebuild-install": "^7.1.1", | ||
| "tar": "^6.1.11" | ||
| "tar": "^6.2.1" |
There was a problem hiding this comment.
6.2.1 has vulns now:
GHSA-34x7-hfp2-rc4v
GHSA-83g3-92jg-28cx
GHSA-r6q2-hw4h-h46w
GHSA-8qq5-rm4j-mr97
might be worth bumping to 7.5.8
Summary
Security Fix
This PR addresses CVE-2024-28863, a denial of service vulnerability in node-tar with a CVSS 3.1 score of 6.5 (Medium).
The vulnerability allows an attacker to craft a malicious tar archive with excessively deep folder hierarchies. When extracted, this can cause uncontrolled resource consumption leading to memory exhaustion and Node.js
process crashes.
Reference: https://nvd.nist.gov/vuln/detail/cve-2024-28863
The fix is included in tar v6.2.1, which prevents extraction in excessively deep subdirectories.
Compatibility
Both updated dependencies maintain compatibility with Node.js 16 and later:
Note
Low Risk
Dependency-only change; main risk is build/install compatibility on environments that still rely on older
node-gyp, but no runtime code paths change.Overview
Updates dependency versions in
package.json: bumpstarto^6.2.1and raisesnode-gypfrom8.xto10.xfor bothpeerDependenciesandoptionalDependencies(impacting the build toolchain used for native rebuilds).Written by Cursor Bugbot for commit 6fef12f. This will update automatically on new commits. Configure here.