Skip to content

fix(tutorials): fix nav footers, restore image captions, add breadcrumb - #329

Merged
petermuessig merged 1 commit into
mainfrom
fix/tutorial-rendering-consistency
Aug 13, 2026
Merged

fix(tutorials): fix nav footers, restore image captions, add breadcrumb#329
petermuessig merged 1 commit into
mainfrom
fix/tutorial-rendering-consistency

Conversation

@petermuessig

Copy link
Copy Markdown
Contributor

Follow-up to #327 addressing a further batch of rendering and consistency issues found while reviewing the GitHub Pages site.

Navigation footers

  • Corrected Next/Previous labels that named the wrong step across the walkthrough: steps 34 and 35 (reported), plus 9 more found while checking the whole chain — 15, 16, 18, 19, 23, 24, 30, 32, 36. Link targets were already correct; only the display text was wrong.
  • OData V4: added the missing Next on step 9 and Previous on step 10, and removed the bogus Next on the last step (11) that looped back to step 1.
  • Normalized footer shape across tutorials: collapsed the doubled *** rule in the navigation steps (the "two gray lines"), and reordered OData V4 so Next/Previous comes before Related Information (matching the other four tutorials).
  • Documented the canonical footer order in AGENTS.md.

Image captions (restore Demo Kit behavior)

  • assets/js/custom.js now auto-renders a caption from each image's alt text (styled in assets/css/custom.css). Alt text was never removed from the repo — only the visible caption was lost in the Demo Kit → Pages migration.
  • Removed the ~42 redundant hand-authored <sup> captions, folding their wording fixes back into the alt/title first so nothing is lost.

Broken OData V4 images

  • Fixed multiline alt-text syntax in steps 2 and 4 (an image whose alt spans two lines doesn't render).
  • Added image files that were referenced but never committed: steps 9 and 11 from the SDK screenshots; steps 5 and 10 reuse the previous step's screenshot ("no visual change").

Quickstart overview

  • Replaced the borrowed step-3 screenshot (which carried a copy-pasted Walkthrough alt text) with the correct SDK image, fixed the alt text, and removed a stray trailing period.

Tutorial breadcrumb

  • Injected a "UI5 Tutorials › <Tutorial>" breadcrumb on every step page (tools/builder/prepare-gh-pages.js for GitHub Pages, tools/dev-server for local preview) so readers know which tutorial they're in and can return to its overview.

Verification

  • npm run typecheck passes; npm run build succeeds.
  • Verified in the browser: captions render (light + dark), breadcrumb links resolve, doubled rules are gone, and all OData V4 images (incl. the previously-broken 9/10/11) now display.

@petermuessig
petermuessig changed the base branch from main to docs/readme-overhaul August 12, 2026 21:02
@petermuessig
petermuessig force-pushed the fix/tutorial-rendering-consistency branch from 6a3a63b to 36c8549 Compare August 12, 2026 21:02
Base automatically changed from docs/readme-overhaul to main August 13, 2026 04:57
@petermuessig
petermuessig requested a review from margopolo August 13, 2026 04:58
Address a batch of rendering and consistency issues found reviewing the
GitHub Pages site.

Navigation footers:
- Correct Next/Previous labels that named the wrong step across the
  walkthrough (34, 35 and 9 more: 15, 16, 18, 19, 23, 24, 30, 32, 36);
  link targets were right, only the display text was wrong.
- OData V4: add the missing Next on step 9 and Previous on step 10,
  drop the bogus Next on the last step (11) that looped back to step 1.
- Normalize footer shape across tutorials: collapse the doubled `***`
  rule in the navigation steps, and reorder OData V4 so Next/Previous
  comes before Related Information (matching the other four tutorials).
- Document the canonical footer order in AGENTS.md.

Image captions (restore Demo Kit behavior):
- Auto-render a caption from each image's alt text in assets/js/custom.js
  (styled in assets/css/custom.css). Alt text was never removed; only
  the visible caption was lost in the migration.
- Remove the ~42 redundant hand-authored <sup> captions, folding their
  wording fixes back into the alt/title first so nothing is lost.

Broken OData V4 images:
- Fix multiline alt-text syntax in steps 2 and 4 (an image whose alt
  spans two lines does not render).
- Add the image files that were referenced but never committed:
  steps 9 and 11 from the SDK screenshots, steps 5 and 10 reuse the
  previous step's screenshot ("no visual change").

Quickstart overview:
- Replace the borrowed step-3 screenshot (which carried a copy-pasted
  Walkthrough alt text) with the correct SDK image, fix the alt text,
  and remove a stray trailing period.

Tutorial breadcrumb:
- Inject a "UI5 Tutorials > <Tutorial>" breadcrumb on every step page
  (tools/builder/prepare-gh-pages.js for GitHub Pages, tools/dev-server
  for local preview) so readers know which tutorial they are in and can
  return to its overview.

@margopolo margopolo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed ...

@petermuessig
petermuessig merged commit a1b4e6a into main Aug 13, 2026
3 checks passed
@petermuessig
petermuessig deleted the fix/tutorial-rendering-consistency branch August 13, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants