fix(ui5-switch): prevent duplicate accessibility announcements#13098
Open
fix(ui5-switch): prevent duplicate accessibility announcements#13098
Conversation
Collaborator
|
🚀 Deployed on https://pr-13098--ui5-webcomponents-preview.netlify.app |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
During manual testing in the Accessbility hub switching the label on and off led to a duplicate announcement (e.g., "ON -> OFF, OFF"). This happened because the first "Off" is the label, and the second is the state - both announced as just "Off".
What We Did
aria-labelattribute, instead of rendering empty string, when no value is provided.What This Fixes
Fixes: #13144