fix(ui5-avatar-group): remove role=button when no overflow and no hasPopup#13709
Open
NakataCode wants to merge 1 commit into
Open
fix(ui5-avatar-group): remove role=button when no overflow and no hasPopup#13709NakataCode wants to merge 1 commit into
NakataCode wants to merge 1 commit into
Conversation
|
🚀 Deployed on https://pr-13709--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix: Conditional ARIA Attributes for Avatar Group
Problem
type="Group"unconditionally exposed:role="button"tabindex="0""Activate for complete list."aria-labelsuffix...even when all avatars fit the container and there was nothing to reveal. Pressing
Enter/Spacefiredui5-clickwith no visible effect, violatingWCAG 2.2 SC 4.1.2 (Name, Role, Value).
Solution
Introduce a
_isInteractiveGroupgetter that returnstrueonly when:_hiddenItems > 0), oraccessibilityAttributes.hasPopupis setGate the following on this getter:
_rolebuttonwhen interactive_ariaLabelTextsuffix_containerAriaHasPopupui5-clickwhen interactiveFixes: #13677