Skip to content

fix(ui5-carousel): fix navigation animation #13762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TeodorTaushanov wants to merge 2 commits into
base: main
Choose a base branch
from
+27 −1
Open

fix(ui5-carousel): fix navigation animation #13762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9612ed6
fix(ui5-carousel): fix navigation animation
TeodorTaushanov Jun 30, 2026
c060566
chore: fix test
TeodorTaushanov Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/main/cypress/specs/Carousel.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,24 @@ describe("Carousel general interaction", () => {
});
});

it("_resizing remains false when navigateTo is called after _onResize", () => {
cy.mount(
<Carousel id="carousel">
<Button>Button 1</Button>
<Button>Button 2</Button>
<Button>Button 3</Button>
</Carousel>
);

cy.get<Carousel>("#carousel")
.then($carousel => {
const carousel = $carousel[0];
carousel._onResize();

@dimovpetar dimovpetar Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to change the width of the carousel via CSS

carousel.navigateTo(2);
expect(carousel._resizing).to.be.false;
});
});

it("items should remain reachable after resizing increases items per page", () => {
const navigateStub = cy.stub().as("navigateStub");

Expand Down
2 changes: 2 additions & 0 deletions packages/main/src/Carousel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,8 @@ class Carousel extends UI5Element {
return;
}

this._resizing = false;

@dimovpetar dimovpetar Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep _changePageIndex clean, without this side effect, I proposed another handling in _onResize


this._currentPageIndex = newPageIndex;
this._updateVisibleItems(newPageIndex);

Expand Down
8 changes: 7 additions & 1 deletion packages/main/test/pages/CarouselPublicMethods.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,14 +238,15 @@
<ui5-li icon="learning-assistant">Tutorials</ui5-li>
</ui5-list>
</ui5-card>

</ui5-carousel>
<ui5-button id="btnNavigate">Check animation after resize - navigate to 5</ui5-button>
</body>

<script>
const navigateLeftBtn = document.getElementById("navigateLeft");
const navigateRightBtn = document.getElementById("navigateRight");
const carousel = document.getElementById("carouselCards");
const btnNavigate = document.getElementById("btnNavigate");

navigateLeftBtn.addEventListener("click", function() {
const newPageIndex = carousel.visibleItemsIndices[0] - 1;
Expand All @@ -256,6 +257,11 @@
const newPageIndex = carousel.visibleItemsIndices[0] + 1;
carousel.navigateTo(newPageIndex);
});

btnNavigate.addEventListener("click", function() {
carousel._onResize();

@dimovpetar dimovpetar Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u replace carousel._onResize(); with something public, like setting the changing the width through CSS?

carousel.navigateTo(5);
});
</script>

</html>
Loading