fix: declare mrr_graph explicitly instead of implicit global

[superdav42]

Summary

Removed eslint-disable comment and added const declaration to mrr_graph variable initialization. This prevents the variable from leaking to global scope and ensures compatibility with strict mode.

Testing

Verified with ESLint - no violations on the modified file.

Resolves #1239

---

aidevops.sh v3.17.14 plugin for OpenCode v1.15.6 with claude-haiku-4-5 spent 2m and 2,861 tokens on this as a headless worker.

Summary by CodeRabbit

• Refactor
  • Improved code quality in the dashboard statistics component by adopting better variable declaration practices and removing unnecessary code comments.

[github-actions]

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

• Build: ultimate-multisite
• ⬇️ Download from GitHub Actions
• ⬇️ Download without Github Account (nightly.link)

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ec9aa2e7-4dbf-4fcb-906c-cc1a5830916b

📥 Commits

Reviewing files that changed from the base of the PR and between a4382d6 and c59a845.

📒 Files selected for processing (1)

• assets/js/dashboard-statistics.js

---

📝 Walkthrough

Walkthrough

The PR addresses a code quality issue by converting an undeclared mrr_graph global variable assignment to a properly scoped const declaration in the dashboard statistics JavaScript file. The inline eslint suppression comment that was masking the undeclared variable is also removed.

Changes

Variable Declaration Fix

Layer / File(s)	Summary
Vue instance declaration assets/js/dashboard-statistics.js	mrr_graph is declared with const instead of an implicit global assignment, eliminating the eslint suppression and preventing strict mode issues.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A global variable, oh what a sight,
Got wrapped in const, now scoped just right!
No more eslint comments to hide the shame,
The rabbit declares it—proper scope is its name! 🎉

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and directly describes the main change: declaring mrr_graph explicitly instead of as an implicit global.
Linked Issues check	✅ Passed	The PR fully addresses the coding requirement from issue #1239: declaring mrr_graph with const at its Vue instantiation and removing the eslint-disable comment.
Out of Scope Changes check	✅ Passed	All changes are directly related to the linked issue #1239 objective of fixing the implicit global variable declaration in dashboard-statistics.js.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/auto-20260520-185441-gh1239

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Performance Test Results

Performance test results for 12e5b56 are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run	DB Queries	Memory	Before Template	Template	WP Total	LCP	TTFB	LCP - TTFB
0	41	37.78 MB	870.50 ms (+38.50 ms / +4% )	150.50 ms (-8.00 ms / -5% )	1050.00 ms (-28.50 ms / -3% )	2006.00 ms	1921.30 ms	81.05 ms (+5.15 ms / +6% )
1	56	49.13 MB	900.50 ms (-48.50 ms / -5% )	144.00 ms	1044.50 ms (-48.00 ms / -5% )	2056.00 ms (-44.00 ms / -2% )	1979.70 ms (-46.05 ms / -2% )	73.00 ms (+2.00 ms / +3% )

[superdav42]

Summary

Removed eslint-disable comment and added const declaration to mrr_graph variable initialization. This prevents the variable from leaking to global scope and ensures compatibility with strict mode.

Testing

Verified with ESLint - no violations on the modified file.

---

aidevops.sh v3.17.14 plugin for OpenCode v1.15.6 with claude-haiku-4-5 spent 2m and 2,861 tokens on this as a headless worker.

---

Merged via PR #1242 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

[superdav42]

Summary

This PR fixes the implicit global variable issue in assets/js/dashboard-statistics.js reported in issue #1239.

Changes

• Removed the eslint-disable-next-line no-undef comment
• Added explicit const declaration to the mrr_graph variable

Verification

✅ All CI checks passed:

• Code Quality Checks: SUCCESS
• PHP Lint: SUCCESS
• All PHP versions (8.2-8.5): SUCCESS
• E2E Tests (8.1, 8.2): SUCCESS
• Build Plugin for Testing: SUCCESS
• WP Performance Metrics: SUCCESS

The fix prevents the variable from leaking to global scope and ensures compatibility with strict mode.

Status: Ready for review and merge
Commits: 1 (wip: declare mrr_graph explicitly instead of implicit global)
Tests: All passing