Imported changes from Oculus-VR:Unity-Graphics:6000.0/17.0.4-subpass#8284
Draft
Torgo13 wants to merge 1 commit intoUnity-Technologies:6000.3/stagingfrom
Draft
Imported changes from Oculus-VR:Unity-Graphics:6000.0/17.0.4-subpass#8284Torgo13 wants to merge 1 commit intoUnity-Technologies:6000.3/stagingfrom
Torgo13 wants to merge 1 commit intoUnity-Technologies:6000.3/stagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
The Oculus-VR fork has branches with Vulkan subpass support for Unity 2022.3 and Unity 6000.0. This branch applies the same changes to Unity 6000.3.
Testing status
The following test projects from the Oculus-VR 17.0.4-subpass branch work correctly in Unity 6000.3.12f1. They display the correct output and demonstrate subpass merging on both Windows and Android devices using the Vulkan API.
DepthInputSubpassSample
PostProcessSubpassSample
Comments to reviewers
Ideally this branch would include the original commits to the Oculus-VR branch to maintain the Git history and credit the original developers. This is a proof-of-concept demonstration that these same changes can be used in a later LTS version of Unity.